Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[android_alarm_manager] Added ability to get id in the callback#1985

Merged
bkonyi merged 7 commits intoflutter:masterfrom
Afsar-Pasha:master
Aug 19, 2019
Merged

[android_alarm_manager] Added ability to get id in the callback#1985
bkonyi merged 7 commits intoflutter:masterfrom
Afsar-Pasha:master

Conversation

@Afsar-Pasha
Copy link
Contributor

@Afsar-Pasha Afsar-Pasha commented Aug 17, 2019 •
edited
Loading

Description

Added ability to get id in the callback.

Related Issues

#31658 Getting alarm ID in callback

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@Afsar-Pasha Afsar-Pasha requested a review from bkonyi as a code owner August 17, 2019 17:33
@Afsar-Pasha Afsar-Pasha changed the title [android_alarm_manager] Added ability to get id in the callback [android_alarm_manager] Added ability to get id in the callback Aug 17, 2019
Cretezy
Cretezy reviewed Aug 18, 2019
View reviewed changes
@Afsar-Pasha @Cretezy
Update packages/android_alarm_manager/CHANGELOG.md
41e75c3 
Co-Authored-By: Charles Crete <charles@cretezy.com>
bkonyi
bkonyi approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me.

@bkonyi bkonyi merged commit 4a7ddd2 into flutter:master Aug 19, 2019
@ahmednet0001
Copy link

ahmednet0001 commented Aug 24, 2019

How I can use it to get ID of alarm in callback ?

ahmednet0001
ahmednet0001 reviewed Aug 24, 2019
View reviewed changes
@Afsar-Pasha Afsar-Pasha mentioned this pull request Aug 27, 2019
Closed
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
@Afsar-Pasha @Cretezy
[android_alarm_manager] Added ability to get id in the callback (flut…
1a64a23 
…ter#1985)

Co-Authored-By: Charles Crete <charles@cretezy.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@Cretezy Cretezy Cretezy left review comments

@ahmednet0001 ahmednet0001 ahmednet0001 left review comments

@bkonyi bkonyi bkonyi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Afsar-Pasha @ahmednet0001 @Cretezy @bkonyi @googlebot